Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(craft-application): migrate version command #4614

Merged

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Feb 26, 2024

This does not include the legacy snapcraft version

Fixes: #4468

@syu-w syu-w force-pushed the work/CRAFT-2315-version-command branch from f1395d5 to a07e074 Compare February 26, 2024 21:21
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.12%. Comparing base (6ff3e0b) to head (943f5b0).
Report is 21 commits behind head on feature/craft-application.

Files Patch % Lines
snapcraft/cli.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/craft-application    #4614      +/-   ##
=============================================================
+ Coverage                      88.83%   89.12%   +0.28%     
=============================================================
  Files                            327      331       +4     
  Lines                          22033    22065      +32     
=============================================================
+ Hits                           19573    19665      +92     
+ Misses                          2460     2400      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This does not include the legacy snapcraft version
@syu-w syu-w force-pushed the work/CRAFT-2315-version-command branch from a07e074 to 943f5b0 Compare February 26, 2024 21:42
@syu-w syu-w requested review from mr-cal and lengau February 27, 2024 16:19
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

tests/unit/cli/test_version.py Show resolved Hide resolved
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerning Alex's comment, I am fine either way. Otherwise looks good!

@sergiusens sergiusens merged commit 885106d into feature/craft-application Feb 28, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants