-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warning unsafe override-prime #4553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, left a question about the wording of the message.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## hotfix/8.0 #4553 +/- ##
==============================================
- Coverage 89.18% 89.17% -0.01%
==============================================
Files 321 321
Lines 21775 21778 +3
==============================================
+ Hits 19419 19421 +2
- Misses 2356 2357 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we only need to adjust the logic for the problem detection -- ELF patching is applied per part so the problem should only happen in patchelf and override-prime are used together in the same part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That should keep the developers aware until we implement a proper solution in craft-parts.
f136894
to
f11d276
Compare
Force pushed due to re-target to hotfix |
No description provided.