Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning unsafe override-prime #4553

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Jan 31, 2024

No description provided.

@syu-w syu-w requested review from cmatsuoka and mr-cal January 31, 2024 18:04
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left a question about the wording of the message.

tests/unit/parts/test_lifecycle.py Outdated Show resolved Hide resolved
snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
@syu-w syu-w requested a review from mr-cal January 31, 2024 23:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e6149f) 89.18% compared to head (f11d276) 89.17%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           hotfix/8.0    #4553      +/-   ##
==============================================
- Coverage       89.18%   89.17%   -0.01%     
==============================================
  Files             321      321              
  Lines           21775    21778       +3     
==============================================
+ Hits            19419    19421       +2     
- Misses           2356     2357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we only need to adjust the logic for the problem detection -- ELF patching is applied per part so the problem should only happen in patchelf and override-prime are used together in the same part.

snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That should keep the developers aware until we implement a proper solution in craft-parts.

@syu-w syu-w changed the base branch from main to hotfix/8.0 February 7, 2024 16:20
@syu-w syu-w changed the base branch from hotfix/8.0 to main February 7, 2024 16:26
@syu-w syu-w changed the base branch from main to hotfix/8.0 February 7, 2024 16:30
@syu-w syu-w force-pushed the work/CRAFT-2443-override-prime-warning branch from f136894 to f11d276 Compare February 7, 2024 16:30
@syu-w
Copy link
Contributor Author

syu-w commented Feb 7, 2024

Force pushed due to re-target to hotfix

@mr-cal mr-cal merged commit 4a3a062 into hotfix/8.0 Feb 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants