Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pack components #4506

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Pack components with snap pack.

Snaps can have custom filenames using --output (i.e. snapcraft pack --output my-dir/my-snap.snap)

However, components cannot. Their names are determined by snap pack. They will still be placed in the same output directory (my-dir in the example above).

Fixes #4467
(CRAFT-2313)

mr-cal added 4 commits January 5, 2024 07:51
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from cmatsuoka and lengau January 5, 2024 16:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/components@d20a073). Click here to learn what that means.

❗ Current head 9a12dad differs from pull request most recent head edcef80. Consider uploading reports for the commit edcef80 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature/components    #4506   +/-   ##
=====================================================
  Coverage                      ?   89.31%           
=====================================================
  Files                         ?      323           
  Lines                         ?    21877           
  Branches                      ?        0           
=====================================================
  Hits                          ?    19540           
  Misses                        ?     2337           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, can you add a spread test for component creation?

snapcraft/pack.py Outdated Show resolved Hide resolved
snapcraft/pack.py Outdated Show resolved Hide resolved
snapcraft/pack.py Outdated Show resolved Hide resolved
snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 8, 2024

pyright failure is unrelated. I don't think pyright is pinned in this branch.

@mr-cal mr-cal requested a review from lengau January 8, 2024 20:40
@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 8, 2024

Pyright failure addressed in #4512

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@mr-cal mr-cal merged commit 71fa126 into feature/components Jan 9, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the CRAFT-2313-pack-components branch January 9, 2024 14:14
@mr-cal mr-cal mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants