-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pack components #4506
feat: pack components #4506
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/components #4506 +/- ##
=====================================================
Coverage ? 89.31%
=====================================================
Files ? 323
Lines ? 21877
Branches ? 0
=====================================================
Hits ? 19540
Misses ? 2337
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, can you add a spread test for component creation?
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
pyright failure is unrelated. I don't think pyright is pinned in this branch. |
Pyright failure addressed in #4512 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
make lint
?pytest tests/unit
?Pack components with
snap pack
.Snaps can have custom filenames using
--output
(i.e.snapcraft pack --output my-dir/my-snap.snap
)However, components cannot. Their names are determined by
snap pack
. They will still be placed in the same output directory (my-dir
in the example above).Fixes #4467
(CRAFT-2313)