Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meta): generate metadata for components #4503

Merged
merged 4 commits into from
Jan 5, 2024
Merged

feat(meta): generate metadata for components #4503

merged 4 commits into from
Jan 5, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 3, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Generate metadata for components and write the metadata to prime/component/<component-name>/meta/component.yaml.

Fixes #4466
(CRAFT-2312)

mr-cal added 3 commits January 3, 2024 13:16
@mr-cal
test(lifecycle): test components on core22
802bb7a 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
feat(project): add get_component_names() function
de1390e 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
feat(meta): generate metadata for components
5875317 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/components@79dcf97). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##             feature/components    #4503   +/-   ##
=====================================================
  Coverage                      ?   89.26%           
=====================================================
  Files                         ?      322           
  Lines                         ?    21802           
  Branches                      ?        0           
=====================================================
  Hits                          ?    19462           
  Misses                        ?     2340           
  Partials                      ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal mr-cal requested review from lengau and syu-w January 3, 2024 21:44
lengau
lengau reviewed Jan 3, 2024
View reviewed changes
snapcraft/projects.py Outdated Show resolved Hide resolved
@mr-cal
chore: feedback from PR
9d07028 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested a review from lengau January 4, 2024 15:38
lengau
lengau approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, but I'm also very nosy so I want to know about any other comments/changes if they come down the pipeline please :-)

@mr-cal mr-cal merged commit d20a073 into feature/components Jan 5, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the CRAFT-2312-component-metadata branch January 5, 2024 13:51
@mr-cal mr-cal mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syu-w syu-w syu-w approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-cal @codecov-commenter @lengau @syu-w