Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/desktop: don't preload bindtextdomain for wine snaps #4501

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mmtrt
Copy link
Contributor

@mmtrt mmtrt commented Dec 20, 2023

fixes that #3738 couldn't

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1e28514) 89.23% compared to head (d43cccf) 89.18%.
Report is 21 commits behind head on main.

❗ Current head d43cccf differs from pull request most recent head f16b471. Consider uploading reports for the commit f16b471 to get more accurate results

Files Patch % Lines
snapcraft/remote/git.py 22.22% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4501      +/-   ##
==========================================
- Coverage   89.23%   89.18%   -0.06%     
==========================================
  Files         322      321       -1     
  Lines       21804    21767      -37     
==========================================
- Hits        19456    19412      -44     
- Misses       2348     2355       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal mr-cal requested a review from kenvandine January 23, 2024 19:27
Copy link
Contributor

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, thanks!

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about this referencing a specific of content snaps but I think it is OK as the wine content snaps are used in many snaps.

Anyways, I can't think of a better alternative.

extensions/desktop/common/init Outdated Show resolved Hide resolved
@mr-cal mr-cal requested a review from lengau January 23, 2024 19:53
@mmtrt mmtrt force-pushed the patch-1 branch 2 times, most recently from f16b471 to 0ab74e7 Compare January 23, 2024 20:19
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @mr-cal that referencing the wine content snaps specifically makes me wary, but this is fine as a workaround for now.

@mr-cal can you think of a way to make this more general?

@sergiusens sergiusens merged commit 58964d8 into canonical:main Feb 14, 2024
8 of 9 checks passed
@mmtrt mmtrt deleted the patch-1 branch February 14, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants