-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions/desktop: don't preload bindtextdomain for wine snaps #4501
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4501 +/- ##
==========================================
- Coverage 89.23% 89.18% -0.06%
==========================================
Files 322 321 -1
Lines 21804 21767 -37
==========================================
- Hits 19456 19412 -44
- Misses 2348 2355 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about this referencing a specific of content snaps but I think it is OK as the wine content snaps are used in many snaps.
Anyways, I can't think of a better alternative.
f16b471
to
0ab74e7
Compare
…e snaps fixes what canonical#3738 couldn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes that #3738 couldn't
make lint
?pytest tests/unit
?