Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump craft-providers to 1.20.1 #4462

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Dec 1, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

This resolves a bug introduced in 1.16.0 where improperly set-up base instances would cause snapcraft to fail with the error Instance setup failed. Check LXD logs for more details.

Changelog

1.20.1

  • Update base compatibility tag from base-v3 to base-v4
  • If an existing base instance is not setup, then it is auto-cleaned.
    If the process that created the not setup base instance is inactive, then
    craft-providers will immediately auto-clean the instance.

1.20.0

  • Snaps injected from the host will have their base snap injected into
    the instance.

@mr-cal mr-cal changed the base branch from main to hotfix/7.5 December 1, 2023 16:35
@mr-cal mr-cal closed this Dec 1, 2023
@mr-cal mr-cal reopened this Dec 1, 2023
@mr-cal mr-cal requested a review from cmatsuoka December 4, 2023 14:09
@mr-cal mr-cal closed this Dec 4, 2023
@mr-cal mr-cal reopened this Dec 4, 2023
@mr-cal mr-cal self-assigned this Dec 4, 2023
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the craft-providers-1.20.1-hotfix branch from 699581e to fe9e7ba Compare December 4, 2023 14:16
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b5c2f4) 94.88% compared to head (fe9e7ba) 94.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           hotfix/7.5    #4462      +/-   ##
==============================================
- Coverage       94.88%   94.88%   -0.01%     
==============================================
  Files             658      658              
  Lines           55192    55192              
==============================================
- Hits            52369    52367       -2     
- Misses           2823     2825       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Dec 6, 2023

Merging with core18 spread test failures because they are unrelated (flutter/flutter#133881)

@mr-cal mr-cal merged commit 7bd0d3a into hotfix/7.5 Dec 6, 2023
13 of 14 checks passed
@mr-cal mr-cal deleted the craft-providers-1.20.1-hotfix branch December 6, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants