feat(cli): add craft-application scaffolding #4456
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
changed the title
|
Appveyor test failure looks like a network connectivity issue, but I can't re-run the test. |
snapcraft/meta/snap_yaml.py
Outdated
| issues: Optional[UniqueStrList] | ||
| source_code: Optional[UniqueStrList] | ||
| website: Optional[UniqueStrList] | ||
| contact: Optional[models.UniqueStrList] |
There was a problem hiding this comment.
I believe we can use craft-application's UniqueStrList here.
There was a problem hiding this comment.
Nice, I switched to this in a few places. Can you check it? I'm not sure if the cast calls are the right approach
There was a problem hiding this comment.
You can do them with casts or just by calling the constructor (the constraint types are subclasses of their actual types). I don't think it makes much difference in code speed.
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
|
Merging despite the Appveyor failure (it passed for the branch but not the PR) and I can't re-run it. As far as I can tell, the test passed but failed when uploading an artifact. This is going into a feature branch, so I'm not too worried. If the Appveyor test continues to be flaky, I'll look into it more. |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
make lint?pytest tests/unit?Adds
craft-applicationscaffolding to snapcraft. This includes migrating to theProjectmodel, adding anApplicationclass, and CLI handling.All commands are unimplemented, raise a
ClassicFallbackerror, and execute the existing snapcraft code.This has the same scope and intent as canonical/rockcraft#353.
This is based on @lengau's work in #4449, which includes this work and more (such as the implementation of lifecycle commands).
(CRAFT-2238)