plugins: kernel: split kernel plugin into kernel and initrd plugins #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4302 +/- ##
==========================================
- Coverage 89.18% 89.16% -0.02%
==========================================
Files 321 324 +3
Lines 21777 21767 -10
==========================================
- Hits 19421 19408 -13
- Misses 2356 2359 +3 ☔ View full report in Codecov by Sentry. |
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
5 times, most recently
from
eba7617 to
a582799
Compare
sergiusens
reviewed
Aug 4, 2023
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
from
a582799 to
a5a92f8
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
from
a5a92f8 to
5e32ec2
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
3 times, most recently
from
05f8b40 to
31c82ab
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
from
31c82ab to
dc6c0b5
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
2 times, most recently
from
41b67a2 to
5e5ab98
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
2 times, most recently
from
27af9d2 to
d5cb90c
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
from
d5cb90c to
394cb31
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
12 times, most recently
from
bac7288 to
aa5485c
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
3 times, most recently
from
4a0f747 to
eeecde2
Compare
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
2 times, most recently
from
9437485 to
ece78b0
Compare
kernel plugin builds two components, kernel and initrd While initrd is dependent on the kernel, it is a separate component. Separating those 2 steps into 2 own plugins will allow greater reuse of the kernel plugin as well as each plugin being owned by respective teams. Initrd steps will always depend on the kernel step, but with the plugin separation, prebuilt kernel binaries can be used with the initrd plugin In the future inird might even become the official way to build kernel snap from kernel deb packages. Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Generic build-environment part option can be used instead. Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
…ined in ubuntu-core-initrd package Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
…ne kernel build Signed-off-by: Ondrej Kubik <ondrej.kubik@canonical.com>
kubiko
force-pushed
the
split_kernel_initrd_plugins
branch
from
ece78b0 to
a1d13d4
Compare
It's been awhile since I left that comment above, but it is still true - just let me know when this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel plugin builds two components, kernel and initrd
While initrd is dependent on the kernel, it is a separate component.
Separating those 2 steps into 2 own plugins will allow greater reuse of the
kernel plugin as well as each plugin being owned by respective teams.
Initrd steps will always depend on the kernel step, but with
the plugin separation, prebuilt kernel binaries can be used with the initrd plugin
In the future inird might even become the official way to build kernel snap
from kernel deb packages.
For simplicity now ignoring signed kernels...