isort: automatic formatting/sorting of imports #2819
Conversation
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Nearly perfect match config to black formatting with one exception: psf/black#251 That gap should be filled with the 'ensure_newline_before_comments=True' that won't be honored until the next version of isort. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Ordering currently matters, so provide a script to perform it. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
| @@ -0,0 +1,7 @@ | |||
| [settings] | |||
There was a problem hiding this comment.
does isort support pyproject.toml?
There was a problem hiding this comment.
It in fact looks like they do!
I agree, but it's not really required if following the import style guide. Regardless, it looks like |
This commit adds an isort configuration that's pretty close to black with one exception.
Add iscript config configuration that's pretty close to black with one exception. Ideally we'll enable this for a perfect match once available: isort removes newlines before standalone comments if the following line is an import of the same group psf/black#251
Add a script to format source code (tools/format-code.sh) reliably.
Add isort check (ignores whitespace) to static tests.
Actually format code. <-- this commit will need to be re-done once the current backlog of PRs is cleared (and this is ready to merge).