sources: introduce SnapcraftSourceNotFoundError #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
requested changes
Jun 19, 2019
|
Will do. |
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
=========================================
Coverage ? 89.06%
=========================================
Files ? 206
Lines ? 14052
Branches ? 2123
=========================================
Hits ? 12516
Misses ? 1085
Partials ? 451
Continue to review full report at Codecov.
|
|
Added tests and simplified some crufty logic I noticed while in there... |
sergiusens
approved these changes
Jun 19, 2019
|
Fixes SNAPCRAFT-VV |
|
Fixed formatting issue. |
Many of the errors seen by users indicate source not found. - introduce SnapcraftSourceNotFoundError with helpful error message - chain to FileNotFoundError raised by shutil.copy2(), a common cause of the captured FileNotFoundError exceptions - add tests to validate - simplify some crufty logic while i'm in here Fixes SNAPCRAFT-VV Fixes SNAPCRAFT-VN Fixes SNAPCRAFT-VV Fixes SNAPCRAFT-TJ Fixes SNAPCRAFT-T9 Fixes SNAPCRAFT-TE Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the errors seen by users indicate source not found.
message
cause of the captured FileNotFoundError exceptions
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?