Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ant plugin: make build file location configurable #2596

Merged
merged 1 commit into from
Jun 13, 2019
Merged

ant plugin: make build file location configurable #2596

merged 1 commit into from
Jun 13, 2019

Conversation

bodewig
Copy link
Contributor

@bodewig bodewig commented Jun 12, 2019

With this the ant plugin can use a build file in a non-default location.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@bodewig
ant plugin: make build file location configurable
ce1e4ac 
Signed-off-by: Stefan Bodewig <stefan.bodewig@freenet.de>
@cjp256
Copy link
Contributor

cjp256 commented Jun 12, 2019

LGTM, tested:
build.xml and absent ant-buildfile (works as expected)
test.xml and absent ant-buildfile (fails as expected)
test.xml specifying ant-buildfile (works as expected)
test.xml specifying invalid ant-buildfile (fails as expected)

@sergiusens sergiusens merged commit 8391f29 into canonical:master Jun 13, 2019
@bodewig bodewig deleted the ant_buildfile_option branch July 4, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjp256 cjp256 cjp256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodewig @cjp256 @sergiusens