rust plugin: fix linker on i386 #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On i386 environment, linker becomes i386-linux-gnu-gcc according to arch_triplet. It causes the following error on build.snapcraft.io: error: linker `i386-linux-gnu-gcc` not found | = note: No such file or directory (os error 2) To fix it, I added _get_linker method to adjust linker name.
|
Hi there, thank you for your contribution. The checklist mentions you have signed the CLA though, if so, was it with another account? |
|
The account is correct. At the time of CI, CLA may be under checking. |
|
that did the trick @dalance |
|
Failed tests are not relevant and being dealt with elsewhere:
|
sergiusens
approved these changes
Jun 7, 2019
sergiusens
pushed a commit
to sergiusens/snapcraft
that referenced
this pull request
Jul 25, 2019
On i386 environment, linker becomes i386-linux-gnu-gcc according to
arch_triplet. It causes the following error on build.snapcraft.io:
error: linker `i386-linux-gnu-gcc` not found
|
= note: No such file or directory (os error 2)
To fix it, I added _get_linker method to adjust linker name.
sergiusens
pushed a commit
to sergiusens/snapcraft
that referenced
this pull request
Jul 25, 2019
On i386 environment, linker becomes i386-linux-gnu-gcc according to
arch_triplet. It causes the following error on build.snapcraft.io:
error: linker `i386-linux-gnu-gcc` not found
|
= note: No such file or directory (os error 2)
To fix it, I added _get_linker method to adjust linker name.
sergiusens
pushed a commit
that referenced
this pull request
Sep 10, 2019
On i386 environment, linker becomes i386-linux-gnu-gcc according to
arch_triplet. It causes the following error on build.snapcraft.io:
error: linker `i386-linux-gnu-gcc` not found
|
= note: No such file or directory (os error 2)
To fix it, I added _get_linker method to adjust linker name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On i386 environment, linker becomes
i386-linux-gnu-gccaccording toarch_triplet. It causes the following error on build.snapcraft.io:
To fix it, I added
_get_linkermethod to adjust linker name../runtests.sh static?./runtests.sh tests/unit?