keyrings: update ROS signing key #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROS Debian repository signing key was recently compromised and forced a key rotation. Stop trusting the old key, and trust the new one. See https://discourse.ros.org/t/9342 for more information. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
|
They're currently in the process of rolling this out, but they need to rebuild their archive which will take time, so don't merge this just yet (the tests will probably fail anyway). Update: Decided to trust both keys for now and remove the old one when the rebuild is complete so no one is broken. |
sergiusens
approved these changes
May 31, 2019
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
feature/ros_key_rotation
branch
from
68704c6 to
e4d1da4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2578 +/- ##
==========================================
+ Coverage 88.96% 88.97% +0.01%
==========================================
Files 204 204
Lines 13954 13956 +2
Branches 2111 2111
==========================================
+ Hits 12414 12418 +4
+ Misses 1093 1092 -1
+ Partials 447 446 -1
Continue to review full report at Codecov.
|
6 tasks
clobrano
pushed a commit
to clobrano-forks/snapcraft
that referenced
this pull request
Jun 8, 2019
The ROS Debian repository signing key was recently compromised and forced a key rotation. Stop trusting the old key, and trust the new one. See https://discourse.ros.org/t/9342 for more information. Continue trusting old key until rotation is complete while rotation takes place. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?The ROS Debian repository signing key was recently compromised and forced a key rotation. This PR adds trust in the new key. It does not yet remove the old key as the rotation is not yet complete. See https://discourse.ros.org/t/9342 for more information.