cli: Add --destructive-mode to clean

[sparkiegeek]

Allow wrapper scripts to pass --destructive-mode to lifecycle commands

Fixes https://bugs.launchpad.net/snapcraft/+bug/1827191

• [ ❌ ] Have you followed the guidelines for contributing?
• [ ☑️ ] Have you signed the CLA?
• [ ❌ ] Have you successfully run ./runtests.sh static?
• [ ❌ ] Have you successfully run ./runtests.sh tests/unit?

---

[cjp256]

Excellent! I was just looking for an option like this yesterday :) Tested, LGTM.

[cjp256]

running static tests, I caught a formatting issue:

--- snapcraft/cli/lifecycle.py	2019-05-29 13:21:04.512712 +0000
+++ snapcraft/cli/lifecycle.py	2019-05-29 13:37:20.879088 +0000
@@ -305,11 +305,11 @@
 )
 @click.option(
     "--destructive-mode",
     is_flag=True,
     required=False,
-    help="Forces snapcraft to try and use the current host to build."
+    help="Forces snapcraft to try and use the current host to build.",
 )
 @click.option("--unprime", is_flag=True, required=False, cls=HiddenOption)
 def clean(parts, use_lxd, destructive_mode, unprime):
     """Remove a part's assets.
 
@@ -317,11 +317,12 @@
     Examples:
         snapcraft clean
         snapcraft clean my-part
     """
     build_environment = get_build_environment(
-        use_lxd=use_lxd, destructive_mode=destructive_mode)
+        use_lxd=use_lxd, destructive_mode=destructive_mode
+    )
     project = get_project(is_managed_host=build_environment.is_managed_host)
 
     if unprime and not build_environment.is_managed_host:
         raise click.BadOptionUsage("--unprime is not a valid option.")

[codecov-io]

Codecov Report

Merging #2577 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
+ Coverage   89.03%   89.06%   +0.02%     
==========================================
  Files         205      205              
  Lines       13986    13987       +1     
  Branches     2118     2118              
==========================================
+ Hits        12453    12458       +5     
+ Misses       1082     1080       -2     
+ Partials      451      449       -2

Impacted Files	Coverage Δ
snapcraft/cli/lifecycle.py	86.86% <100%> (+0.09%)	⬆️
snapcraft/cli/_options.py	89.47% <0%> (+5.26%)	⬆️
snapcraft/cli/env.py	77.77% <0%> (+11.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cd034...cea45f8. Read the comment docs.