cli: refactor re-execution into legacy #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
rexec-refactor
branch
3 times, most recently
from
c1b5a84 to
8fb4ca5
Compare
cjp256
reviewed
May 28, 2019
|
Did some testing: cleanbuild with and without legacy, looked good. Ran unit tests, looked good. Ran refresh, update, search, and define -- looked good too. |
Codecov Report
@@ Coverage Diff @@
## master #2571 +/- ##
=========================================
Coverage ? 89.01%
=========================================
Files ? 205
Lines ? 13986
Branches ? 2118
=========================================
Hits ? 12450
Misses ? 1083
Partials ? 453
Continue to review full report at Codecov.
|
This refactor makes it easy to still use the old commands regardless of the existence of a base in the project and to use the store related commands from non-legacy regardless of where this is run from. To acheive this, the decision to re-execute into legacy is in the lifecycle logic by checking for the existence of a base and by providing hidden commands for the older, previously unavailable, commands. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
rexec-refactor
branch
from
d8b79f4 to
8e8a4e1
Compare
|
Did some testing on latest: cleanbuild with and without legacy, refresh, update, search, and define -- all systems seemed fine. LGTM |
cjp256
approved these changes
May 31, 2019
cmatsuoka
approved these changes
May 31, 2019
clobrano
pushed a commit
to clobrano-forks/snapcraft
that referenced
this pull request
Jun 8, 2019
This refactor makes it easy to still use the old commands regardless of the existence of a base in the project and to use the store related commands from non-legacy regardless of where this is run from. To achieve this, a new class command inherited from click.Command was created that can detect if invocation of the legacy code base is required. Simple skeletons to handle remote parts, search, update and define, were created that simply execute into the legacy snapcraft. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor makes it easy to still use the old commands regardless of the
existence of a base in the project and to use the store related commands
from non-legacy regardless of where this is run from.
To achieve this, a new class command inherited from click.Command
was created that can detect if invocation of the legacy code base is
required.
Simple skeletons to handle remote parts, search, update and define,
were created that simply execute into the legacy snapcraft.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?