manifest: expose snapcraft-started-at #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose snapcraft-started-at in the manifest.yaml to use as an ordering mechanism when processing snaps coming into the Snap Store. LP: #1806658 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cmatsuoka
approved these changes
May 7, 2019
| @@ -18,16 +18,20 @@ | |||
| import os | |||
| import json | |||
| from collections import OrderedDict | |||
| from typing import Any, Dict # noqa: F401 | |||
| from typing import Any, Dict, TYPE_CHECKING | |||
There was a problem hiding this comment.
Ah interesting, I was looking for a constant like this one to avoid importing packages just for type checking.
| manifest = OrderedDict() # type: Dict[str, Any] | ||
| manifest["snapcraft-version"] = snapcraft._get_version() | ||
| manifest["snapcraft-started-at"] = project._get_start_time().isoformat() + "Z" |
There was a problem hiding this comment.
I don't like the way Python deals with times without timezones, but it's not something we can change right now.
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
- Coverage 88.85% 88.82% -0.04%
==========================================
Files 202 202
Lines 13794 13801 +7
Branches 2088 2089 +1
==========================================
+ Hits 12257 12259 +2
- Misses 1093 1095 +2
- Partials 444 447 +3
Continue to review full report at Codecov.
|
sparkiegeek
reviewed
May 8, 2019
sergiusens
commented
May 8, 2019
Co-Authored-By: sergiusens <sergio.schvezov@canonical.com>
clobrano
pushed a commit
to clobrano-forks/snapcraft
that referenced
this pull request
Jun 8, 2019
Expose snapcraft-started-at in the manifest.yaml to use as an ordering mechanism when processing snaps coming into the Snap Store. LP: #1806658 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose snapcraft-started-at in the manifest.yaml to use as an ordering
mechanism when processing snaps coming into the Snap Store.
LP: #1806658
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?