extensions: block direct use of private extensions #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't directly load extensions if their name starts with an underscore. These extensions are internal and shouldn't be available for public consumption, to avoid spawn new unanticipated scenarios that need to be supported forever. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
sergiusens
approved these changes
May 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #2555 +/- ##
==========================================
- Coverage 88.86% 88.85% -0.02%
==========================================
Files 202 202
Lines 13789 13791 +2
Branches 2085 2086 +1
==========================================
Hits 12254 12254
- Misses 1092 1093 +1
- Partials 443 444 +1
Continue to review full report at Codecov.
|
clobrano
pushed a commit
to clobrano-forks/snapcraft
that referenced
this pull request
Jun 8, 2019
Don't directly load extensions if their name starts with an underscore. These extensions are internal and shouldn't be available for public consumption, to avoid spawn new unanticipated scenarios that need to be supported forever. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't directly load extensions if their name starts with an underscore. These
extensions are internal and shouldn't be available for public consumption,
to avoid spawn new unanticipated scenarios that need to be supported forever.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com
./runtests.sh static?./runtests.sh tests/unit?