storeapi: move from details (v1) to info (v2) #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of accessing each element from the returned calls as dictionary elements, this implementation offers classes with attributes and some methods to interact with the API results. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cprov
reviewed
May 2, 2019
| params = dict() | ||
| params[ | ||
| "fields" | ||
| ] = "channel-map, snap,snap-id,name,publisher,confinement,revision" |
There was a problem hiding this comment.
There is a stray space before snap, but this field doesn't not exist and it's not needed anyway.
There was a problem hiding this comment.
removed, valid fields are not documented though, are they? they also seem to be flattened, correct?
| :return Details for the snap. | ||
| :rtype: dict | ||
| :return information for the snap. | ||
| :rtype: SnapInfo | ||
| """ | ||
| headers = self.get_default_headers() | ||
| headers.update( | ||
| { | ||
| "Accept": "application/hal+json", |
There was a problem hiding this comment.
v2 responses are technically only application/json, we can drop the hal+ part
Codecov Report
@@ Coverage Diff @@
## master #2550 +/- ##
==========================================
- Coverage 89.02% 88.86% -0.17%
==========================================
Files 201 202 +1
Lines 13611 13772 +161
Branches 2067 2079 +12
==========================================
+ Hits 12117 12238 +121
- Misses 1056 1090 +34
- Partials 438 444 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of accessing each element from the returned calls as dictionary
elements, this implementation offers classes with attributes and some
methods to interact with the API results.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?This implementation strays away from the existing implementation pattern of what lives in the storeapi package but I personally think, even if more work initially, will provide easier ways to interact with the results when the Snap Store API is not fresh in your head.