catkin plugin: use build-packages for compilers #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrofa
force-pushed
the
bugfix/1827148/catkin_remove_compilers
branch
3 times, most recently
from
8fba20f to
28320ef
Compare
|
(#2548 is needed before tests will pass) |
Currently, the Catkin plugin pulls compilers off to the side rather than requesting that they be installed on the host. The reason for this is historical at this point: before bases existed, one could build a ROS snap on any version of Ubuntu, even versions unsupported by the ROS distribution being used. In an effort to ensure this worked as well as possible, the Catkin plugin did as much as it could without utilizing `build-packages` to ensure all components were compatible. With the introduction of bases (and the fact that the only ROS1 releases available correspond to LTS releases, and thus bases), this is no longer a concern. It's no longer possible to build a ROS snap on an unsupported Ubuntu version in a supported manner. Add to that the fact that there's a bug in the plugin's use of the compilers that prevents rebuilds from working properly, and it's time to get rid of them. Rather than pulling compilers off to the side, simply specify them as required `build-packages`. LP: #1827148 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
bugfix/1827148/catkin_remove_compilers
branch
from
28320ef to
df4a1a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
=========================================
- Coverage 89.08% 89% -0.09%
=========================================
Files 201 201
Lines 13657 13611 -46
Branches 2067 2067
=========================================
- Hits 12166 12114 -52
- Misses 1051 1057 +6
Partials 440 440
Continue to review full report at Codecov.
|
sergiusens
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?Currently, the Catkin plugin pulls compilers off to the side rather than requesting that they be installed on the host. The reason for this is historical at this point: before bases existed, one could build a ROS snap on any version of Ubuntu, even versions unsupported by the ROS distribution being used. In an effort to ensure this worked as well as possible, the Catkin plugin did as much as it could without utilizing
build-packagesto ensure all components were compatible.With the introduction of bases (and the fact that the only ROS1 releases available correspond to LTS releases, and thus bases), this is no longer a concern. It's no longer possible to build a ROS snap on an unsupported Ubuntu version in a supported manner. Add to that the fact that there's a bug in the plugin's use of the compilers that prevents rebuilds from working properly, and it's time to get rid of them.
Rather than pulling compilers off to the side, this PR fixes LP: #1827148 by simply specifying them as required
build-packages.