rust plugin: fix usage of rust-channel #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustup.sh no longer accepts a --channel argument. Fix by setting up the toolchain using rustup. For consistency, do not install the default toolchain on toolchain setup and instead use the former mechanism for all code paths. Lastly, remove an unsued variable in RustPlugin._get_toolchain LP: #1825062 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
rust-channel
branch
from
47c8726 to
1332076
Compare
|
the test failure is due to catkin tests failing, unrelated to changes here. |
cmatsuoka
approved these changes
Apr 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
- Coverage 89.1% 89.09% -0.01%
==========================================
Files 201 201
Lines 13660 13657 -3
Branches 2068 2067 -1
==========================================
- Hits 12172 12168 -4
Misses 1050 1050
- Partials 438 439 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustup.sh no longer accepts a --channel argument. Fix by setting up the
toolchain using rustup.
For consistency, do not install the default toolchain on toolchain setup
and instead use the former mechanism for all code paths.
Lastly, remove an unsued variable in RustPlugin._get_toolchain
LP: #1825062
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?