Add SNAPCRAFT_PROJECT_DIR environment variable. #2534
Conversation
New variable pointing to the project directory, the directory the snapcraft command was run from. This variable should be correct regardless of what build environment (container or host) the build is running in. This allows easy reference to supporting script or other resources inside snapcraft.yaml overrides sections. Fixes https://bugs.launchpad.net/snapcraft/+bug/1824417
| @@ -175,7 +175,7 @@ def test_tab_in_yaml(self): | |||
| self.assertThat( | |||
| raised.message, | |||
| Equals( | |||
| "found a tab character that violate intendation on line 5, column 1" | |||
| "found a tab character that violate indentation on line 5, column 1" | |||
There was a problem hiding this comment.
ha, the test failure is due to this change, the typo is in the actual product, feel free to fix it.
There was a problem hiding this comment.
That's weird the tests pass for me with this change? I'll investigate.
There was a problem hiding this comment.
Was due to changes in libyaml - committed fix
Forgot to run "./runtests.sh static" on prev commit
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
==========================================
- Coverage 89.1% 89.09% -0.01%
==========================================
Files 201 201
Lines 13658 13658
Branches 2068 2068
==========================================
- Hits 12170 12169 -1
Misses 1050 1050
- Partials 438 439 +1
Continue to review full report at Codecov.
|
|
A todo or bug to add a proper integration tests in tests/spread/build-providers would be nice to follow-up with (depends on snapd 2.38 and implementation using the new "snap-retrieval" API) |
New variable pointing to the project directory, the directory
the snapcraft command was run from. This variable should be correct
regardless of what build environment (container or host) the build
is running in. This allows easy reference to supporting script or
other resources inside snapcraft.yaml overrides sections.
Fixes https://bugs.launchpad.net/snapcraft/+bug/1824417
./runtests.sh static?./runtests.sh tests/unit?