build providers: support for provider setup #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move checks and setup to the provider implementation. LP: #1821586 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
build-provider-setup
branch
from
1ffa120 to
e6a4c0d
Compare
cmatsuoka
reviewed
Mar 25, 2019
| "Install {command!r} or if already installed, ensure it is " | ||
| "on the system PATH, and try again." | ||
| ) | ||
| fmt = "You need {provider!r} setup to build snaps: {error_message}." |
There was a problem hiding this comment.
Shouldn't this be "set up"?
cmatsuoka
requested changes
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #2515 +/- ##
=========================================
Coverage ? 90.01%
=========================================
Files ? 198
Lines ? 13379
Branches ? 2023
=========================================
Hits ? 12043
Misses ? 909
Partials ? 427
Continue to review full report at Codecov.
|
cmatsuoka
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move checks and setup to the provider implementation.
LP: #1821586
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?