meta: fix management of snap/local #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not copy snap/local into the snap, furthermore, improve the copy logic to work better with embedded directories. Fixes SNAPCRAFT-J2 Fixes SNAPCRAFT-JB Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
sentry-local
branch
from
e2f6bdb to
f739eb7
Compare
kyrofa
reviewed
Mar 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
=========================================
Coverage ? 89.92%
=========================================
Files ? 198
Lines ? 13356
Branches ? 2021
=========================================
Hits ? 12011
Misses ? 921
Partials ? 424
Continue to review full report at Codecov.
|
cmatsuoka
reviewed
Mar 15, 2019
| snap_dir_iter = itertools.product([prime_snap_dir], ["hooks"]) | ||
| meta_dir_iter = itertools.product([self._meta_dir], ["hooks", "gui"]) | ||
|
|
||
| for origin in itertools.chain(snap_dir_iter, meta_dir_iter): |
There was a problem hiding this comment.
This is a bit convoluted way to set src_dir and dst_dir, I hope we still understand the logic in the future. Perhaps we could add a small comment to clarify our intention?
cmatsuoka
requested changes
Mar 15, 2019
cmatsuoka
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not copy snap/local into the snap, furthermore, improve the copy
logic to work better with embedded directories.
Fixes SNAPCRAFT-J2
Fixes SNAPCRAFT-JB
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?