nodejs pluging: support for type str bin entries #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin was only capable of parsing bin entries inside package.json of type dict, this adds support for str entries, taking into account scoped package names. LP: #1817553 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
bugfix/1817553/nodejs-bin
branch
from
fb2b29c to
3c572ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #2501 +/- ##
=========================================
Coverage ? 89.92%
=========================================
Files ? 198
Lines ? 13364
Branches ? 2023
=========================================
Hits ? 12018
Misses ? 922
Partials ? 424
Continue to review full report at Codecov.
|
cmatsuoka
requested changes
Mar 13, 2019
cmatsuoka
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin was only capable of parsing bin entries inside package.json
of type dict, this adds support for str entries, taking into account
scoped package names.
LP: #1817553
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?