Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: support the use of build-aux/snap #2496

Merged
merged 4 commits into from
Mar 12, 2019

Conversation

sergiusens
Copy link
Collaborator

Many projects required an alternate snap directory to store
snapcraft related assets, in particular Gnome relate projects
have consolidated with the use of build-aux which snapcraft
is now adopting as an alternative as well.

LP: #1805219

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens sergiusens marked this pull request as ready for review March 9, 2019 18:55
Many projects required an alternate snap directory to store
snapcraft related assets, in particular Gnome relate projects
have consolidated with the use of build-aux which snapcraft
is now adopting as an alternative as well.

This also solves the problem where an alternative was needed
in order to build snapd.

LP: #1805219

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

codecov-io commented Mar 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@47141bf). Click here to learn what that means.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2496   +/-   ##
=========================================
  Coverage          ?   89.91%           
=========================================
  Files             ?      198           
  Lines             ?    13360           
  Branches          ?     2022           
=========================================
  Hits              ?    12013           
  Misses            ?      922           
  Partials          ?      425
Impacted Files Coverage Δ
snapcraft/project/_get_snapcraft.py 83.33% <ø> (ø)
snapcraft/project/_project.py 92% <100%> (ø)
snapcraft/internal/meta/_snap_packaging.py 91.08% <100%> (ø)
snapcraft/cli/lifecycle.py 76.02% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47141bf...ffc9447. Read the comment docs.

@sergiusens sergiusens merged commit 4c92c1b into canonical:master Mar 12, 2019
@sergiusens sergiusens deleted the build-aux branch March 12, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants