colcon plugin: support build-time chaining #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until recently, colcon had a bug that caused it to not chain workspaces at build-time. That was recently fixed in a way that broke the colcon plugin. Rework the plugin to rely more on the setup files and less on environment variables to avoid this issue in the future. LP: #1816565 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
sergiusens
reviewed
Feb 25, 2019
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #2486 +/- ##
=========================================
Coverage ? 89.88%
=========================================
Files ? 198
Lines ? 13339
Branches ? 2021
=========================================
Hits ? 11990
Misses ? 924
Partials ? 425
Continue to review full report at Codecov.
|
sergiusens
reviewed
Feb 26, 2019
| # overall, but it defines it after this function runs. Some ROS | ||
| # tools will cause binaries to be run when we source the setup.sh, | ||
| # below, so we need to have a sensible LD_LIBRARY_PATH before then. | ||
| 'LD_LIBRARY_PATH="$LD_LIBRARY_PATH:{}"'.format( |
There was a problem hiding this comment.
Good to see this go away
sergiusens
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?Until recently, colcon had a bug that caused it to not chain workspaces at build-time. That was recently fixed in a way that broke the colcon plugin. This PR fixes LP: #1816565 by reworking the plugin to rely more on the setup files and less on environment variables to avoid this issue in the future.