store: support registering to a specific store #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkiegeek
suggested changes
Feb 21, 2019
There was a problem hiding this comment.
Think we should call this store instead of store-id - there are unfortunately many ways to refer to a store, and the API docs call it store
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
=========================================
Coverage ? 89.94%
=========================================
Files ? 198
Lines ? 13367
Branches ? 2024
=========================================
Hits ? 12023
Misses ? 921
Partials ? 423
Continue to review full report at Codecov.
|
sergiusens
force-pushed
the
register-on-store-brand
branch
from
3e0ec18 to
bd3010c
Compare
cmatsuoka
approved these changes
Mar 13, 2019
cprov
reviewed
Mar 14, 2019
Add a --store-id option to the register command. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-Authored-By: sergiusens <sergio.schvezov@canonical.com>
Revert mass store_id rename to only the user facing bits as store is an object used in decorators and contexts that take precedence Add an integration test for a valid registration and an invalid one. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
register-on-store-brand
branch
from
7e7af7e to
1ebf63f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --store-id option to the register command.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?