Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many: support for stage-snaps #2468

Merged
merged 5 commits into from
Feb 13, 2019
Merged

many: support for stage-snaps #2468

merged 5 commits into from
Feb 13, 2019

Conversation

sergiusens
Copy link
Collaborator

Add support for stage-snaps, with support for advanced grammar. Support for a snap
source was added to be able to extract the downloaded snaps.

LP: #1805214

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens
many: support for stage-snaps
81f0440 
Add support for stage-snaps, with support for advanced grammar. Support for a snap
source was added to be able to extract the downloaded snaps.

LP: #1805214

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

codecov-io commented Feb 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cd9516b). Click here to learn what that means.
The diff coverage is 69.47%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2468   +/-   ##
========================================
  Coverage          ?   89.9%           
========================================
  Files             ?     198           
  Lines             ?   13361           
  Branches          ?    2021           
========================================
  Hits              ?   12012           
  Misses            ?     925           
  Partials          ?     424
Impacted Files Coverage Δ
snapcraft/internal/sources/__init__.py 89.28% <100%> (ø)
snapcraft/internal/sources/errors.py 97.43% <100%> (ø)
snapcraft/_baseplugin.py 94.31% <100%> (ø)
snapcraft/internal/pluginhandler/__init__.py 89.78% <41.17%> (ø)
snapcraft/internal/sources/_snap.py 65.11% <65.11%> (ø)
snapcraft/internal/repo/errors.py 82.27% <75%> (ø)
...ader/grammar_processing/_part_grammar_processor.py 91.3% <83.33%> (ø)
snapcraft/internal/repo/snaps.py 89.13% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9516b...b16283d. Read the comment docs.

@sergiusens sergiusens removed the squash label Feb 12, 2019
@sergiusens sergiusens changed the title [WIP] many: support for stage-snaps many: support for stage-snaps Feb 12, 2019
cmatsuoka
cmatsuoka requested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and well structured, I just found a few points to nitpick.

snapcraft/internal/sources/_snap.py Outdated
@@ -0,0 +1,116 @@
# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
#
# Copyright (C) 2019 Canonical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be "Canonical Ltd"?

snapcraft/internal/sources/errors.py
@@ -1,6 +1,6 @@
# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
#
# Copyright (C) 2015-2017 Canonical Ltd
# Copyright (C) 2015-2017, 2019 Canonical Ltd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if copyright notices must have this year-by-year granularity, or just start to most recent modification is enough. I use the latter in my works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we had a long discussion with legal on how to do it, maybe I can pull out the thread

snapcraft/internal/sources/errors.py Outdated

fmt = (
"The snap file used does not contain valid data. "
"Ensure a proper snap file is passed for .snap files "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here sounds a bit strange. Perhaps something like "The snap file does not contain valid data. Ensure the source lists a proper snap file" could be better?

@sergiusens sergiusens merged commit 0983e40 into canonical:master Feb 13, 2019
@sergiusens sergiusens deleted the stage-snaps branch February 13, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiusens @codecov-io @cmatsuoka