cli: implement list-plugins #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help command has been migrated. Tests other than unit have been disabled until the transition is complete. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cmatsuoka
added a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Mar 29, 2019
There are bugs in patchelf addressed by patches not yet available in a stable release. Until a new version of patchelf is released, use a custom build with specific patches cherry-picked from the development tree. Currently we're addressing the following issues: - no-rpath-prebuild: force pagesize to 4096 on prebuilt binaries - Avoid inflating file sizes needlessly and allow binaries to be stripped - patchelf --set-interpreter fails with `cannot find section ` (canonical#66) - --set-interpreter gives "cannot find section" for go binary (canonical#138) Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
added a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Mar 29, 2019
Pull patchelf from the latest stable tag from the upstream repository, which contains patches critical for snapcraft to work properly with Go ELF binaries. Noteworthy patches and issues fixed: - Avoid inflating file sizes needlessly and allow binaries to be stripped - patchelf --set-interpreter fails with `cannot find section` (canonical#66) - --set-interpreter gives "cannot find section" for go binary (canonical#138) LP: #1805205 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
4 tasks
sergiusens
pushed a commit
that referenced
this pull request
Apr 8, 2019
Pull patchelf from the latest stable tag from the upstream repository, which contains patches critical for snapcraft to work properly with Go ELF binaries. Patchelf 0.10 is able to correctly set the interpreter, so the workaround put in place for previous versions is no longer necessary. When building for classic confinement, relink dynamic go executables so that patchelf will succeed when setting rpath. Noteworthy issues fixed in patchelf 0.10 are: - Avoid inflating file sizes needlessly and allow binaries to be stripped - patchelf --set-interpreter fails with `cannot find section` (#66) - --set-interpreter gives "cannot find section" for go binary (#138) LP: #1805205 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
xnox
pushed a commit
to xnox/snapcraft
that referenced
this pull request
Jul 3, 2020
…onical#2519) Pull patchelf from the latest stable tag from the upstream repository, which contains patches critical for snapcraft to work properly with Go ELF binaries. Patchelf 0.10 is able to correctly set the interpreter, so the workaround put in place for previous versions is no longer necessary. When building for classic confinement, relink dynamic go executables so that patchelf will succeed when setting rpath. Noteworthy issues fixed in patchelf 0.10 are: - Avoid inflating file sizes needlessly and allow binaries to be stripped - patchelf --set-interpreter fails with `cannot find section` (canonical#66) - --set-interpreter gives "cannot find section" for go binary (canonical#138) LP: #1805205 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.