cli: disable raven if not running from package

In order to avoid bogus environment misconfiguration reports, only allow
Sentry submissions if running from the packaged distribution.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

snapcraft/cli/_errors.py

@@ -30,6 +30,7 @@
 import snapcraft
 from snapcraft.config import CLIConfig as _CLIConfig
 from snapcraft.internal import errors
+from snapcraft.internal.common import is_snap
 from snapcraft.internal.build_providers.errors import ProviderExecError
 
 # raven is not available on 16.04
@@ -113,7 +114,7 @@ def exception_handler(  # noqa: C901
     is_snapcraft_reportable_error = issubclass(
         exception_type, errors.SnapcraftReportableError
     )
-    is_raven_setup = RavenClient is not None
+    is_raven_setup = RavenClient is not None if is_snap() else False
     is_connected_to_tty = (
         # used by inner instance, variable set by outer instance
         (distutils.util.strtobool(os.getenv("SNAPCRAFT_HAS_TTY", "n")) == 1)

tests/unit/cli/test_errors.py

@@ -29,7 +29,7 @@
 import snapcraft.internal.errors
 from snapcraft.internal.build_providers.errors import ProviderExecError
 from snapcraft.cli._errors import exception_handler
-from tests import unit
+from tests import fixture_setup, unit
 
 
 class TestSnapcraftError(snapcraft.internal.errors.SnapcraftError):
@@ -47,6 +47,8 @@ class ErrorsBaseTestCase(unit.TestCase):
     def setUp(self):
         super().setUp()
 
+        self.useFixture(fixture_setup.FakeSnapcraftIsASnap())
+
         patcher = mock.patch("sys.exit")
         self.exit_mock = patcher.start()
         self.addCleanup(patcher.stop)