Cosmetic fixes to readme #6
Conversation
README.md
Outdated
| @@ -50,7 +50,7 @@ jobs: | |||
|
|
|||
| - name: Setup LXD | |||
| uses: canonical/setup-lxd@[version] | |||
| # uses pre-installed LXD snap (v4.0.9) | |||
| # uses pre-installed LXD snap (5.0/stable) | |||
There was a problem hiding this comment.
Pretty sure 20.04 ships with LXD 4.0.9, maybe change the runner version to 20.04 here instead?
There was a problem hiding this comment.
Think it's more clear to have a contrast with the other example
There was a problem hiding this comment.
Pretty sure 20.04 ships with LXD 4.0.9, maybe change the runner version to 20.04 here instead?
Indeed, 20.04 ships with 4.0/stable which currently has 4.0.9 but the job has runs-on: ubuntu-22.04 which means it comes 5.0/stable pre-installed.
There was a problem hiding this comment.
Think it's more clear to have a contrast with the other example
Sure, having both example end up using 5.0/stable is probably not ideal. How about using latest/stable for the 22.04 one?
There was a problem hiding this comment.
I settled on a slightly different version, please let me know what you think.
`ubuntu-latest` being a moving target, we risk asking for LXD to be downgraded (not supported) if we track `5.0/stable`. Avoid the problem by using `latest/stable` instead of the distro's LTS track that comes pre-installed. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
cosmetic-fixes-to-readme
branch
from
8976504 to
df45a0f
Compare
No description provided.