Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the interfaces up after configuration #108

Merged

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Jul 10, 2024

Description

Fixes the Network is unreachable problem which is described below by making the interfaces up after UPF network configuration.

Env is an EC2 instance. Two additional interfaces attached for access and core.
Configuration passed to the charm included interface name, interface IP and gateway IP.
Network interfaces are configured correctly, but both are `DOWN`. 
Charm code should make sure that the interfaces have been brought UP after changing configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici requested a review from a team as a code owner July 10, 2024 20:27
@gatici gatici marked this pull request as draft July 11, 2024 08:11
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici marked this pull request as ready for review July 11, 2024 09:27
@gatici gatici changed the title fix: Make the interfaces up after configuration fix: make the interfaces up after configuration Jul 11, 2024
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
src/upf_network.py Show resolved Hide resolved
Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici merged commit 1577f6a into main Jul 11, 2024
21 checks passed
@gatici gatici deleted the TELCO-1280-interfaces-are-brought-up-after-changing-configuration branch July 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants