Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused variable #209

Merged
merged 5 commits into from
Apr 17, 2024
Merged

chore: Remove unused variable #209

merged 5 commits into from
Apr 17, 2024

Conversation

markbeierl
Copy link
Contributor

@markbeierl markbeierl commented Apr 11, 2024

Description

Explicitly set the track to use for each module.

Checklist:

@markbeierl markbeierl requested a review from a team as a code owner April 11, 2024 18:54
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but before merging, I suggest you change the title of the PR as it does not seem to match and the commit message will be that title.

@markbeierl markbeierl changed the title chore: Switch NMS track to 0.2 chore: Remove unused variables Apr 12, 2024
@markbeierl
Copy link
Contributor Author

Turns out these are not needed. @Gmerold, should I be deleting all these files, or are some stiff used?

@markbeierl markbeierl changed the title chore: Remove unused variables chore: Remove unused variable Apr 12, 2024
@Gmerold
Copy link
Contributor

Gmerold commented Apr 16, 2024

Turns out these are not needed. @Gmerold, should I be deleting all these files, or are some stiff used?

Not sure what do you mean by all these files, as I only see the removal of one variable. And that one is unused indeed and should be removed.

@markbeierl
Copy link
Contributor Author

Not sure what do you mean by all these files, as I only see the removal of one variable. And that one is unused indeed and should be removed.

I meant to ask if any of the files in this directory were being used or are they all deprecated now?

@Gmerold
Copy link
Contributor

Gmerold commented Apr 17, 2024

Not sure what do you mean by all these files, as I only see the removal of one variable. And that one is unused indeed and should be removed.

I meant to ask if any of the files in this directory were being used or are they all deprecated now?

Oh, ok. Yes, these files are very much being used. The official SD-Core root module doesn't contain the router and the gnbsim, both of which are needed for the tests. This module here combines all the required pieces.

@markbeierl markbeierl merged commit 05b19c0 into main Apr 17, 2024
13 checks passed
@markbeierl markbeierl deleted the TELCO-1123_switch-track branch April 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants