-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unused variable #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but before merging, I suggest you change the title of the PR as it does not seem to match and the commit message will be that title.
Turns out these are not needed. @Gmerold, should I be deleting all these files, or are some stiff used? |
Not sure what do you mean by |
I meant to ask if any of the files in this directory were being used or are they all deprecated now? |
Oh, ok. Yes, these files are very much being used. The official SD-Core root module doesn't contain the router and the gnbsim, both of which are needed for the tests. This module here combines all the required pieces. |
Description
Explicitly set the track to use for each module.
Checklist:
N/A I have added tests that validate the behaviour of the software
N/A I have bumped the version of the library