Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump juju to 3.4 #32

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chore: bump juju to 3.4 #32

merged 1 commit into from
Feb 23, 2024

Conversation

gruyaume
Copy link
Contributor

Description

bump juju version from 3.1 to 3.4

@gruyaume gruyaume requested a review from a team as a code owner February 21, 2024 20:52
markbeierl
markbeierl approved these changes Feb 22, 2024
View reviewed changes
Copy link

@markbeierl markbeierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough, but how has this been tested?

What I mean is, say there were a breaking change in 3.4 that we don't see until the NRF integration test is run. Do we need to verify 3.4 in all our integration tests manually prior to doing a PR like this?

@gruyaume
Copy link
Contributor Author

Seems simple enough, but how has this been tested?

What I mean is, say there were a breaking change in 3.4 that we don't see until the NRF integration test is run. Do we need to verify 3.4 in all our integration tests manually prior to doing a PR like this?

This is a good point related to any change in this repo (not specifically this one). We probably should add some triggers to run CI for the project's dependants

@gruyaume gruyaume merged commit 42d34ef into main Feb 23, 2024
@gruyaume gruyaume deleted the dev-juju3.4 branch February 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbeierl markbeierl markbeierl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @markbeierl