-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps, fix build on main #796
Conversation
tigarmo
commented
Jan 28, 2025
- Have you signed the CLA?
❯ uv lock --upgrade Updated codespell v2.4.0 -> v2.4.1 Updated craft-application v4.6.0 -> v4.8.2 Updated craft-parts v2.3.0 -> v2.4.1 Updated isort v5.13.2 -> v6.0.0 Updated pylint v3.3.3 -> v3.3.4 Updated sphinx-notfound-page v1.0.4 -> v1.1.0
Poetry >=2.0 drops support for the "export" command by default, delegating it to the poetry-plugin-export plugin. These are dev-dependencies only.
Versions <0.109.1 are subject to PYSEC-2024-38 https://osv.dev/vulnerability/PYSEC-2024-38
The test builds the docs over the project files that are sent to the spread worker. However, these files might include files generated by spread tests that executed first, making the test fail unpredictably.
ac582b6
to
d6e1054
Compare
d6e1054
to
5a186fa
Compare
Re: Spread test failures: I'm not sure why they're failing, but they appear to be reaching the right point. We're matching on "No suitable Python interpreter found, giving up." which we do get to, but for some reason doesn't get included in the output:
I don't think these are reversions - they look more like flaky tests to me. Under that presumption I'm approving |
I'm 90% sure that the new error-output-handling is flaky in this special case. That expected line is the very last line of error output, and sometimes the test passes. |
@tigarmo makes sense to me. I can't replicate the issue on my own machine. |