Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, fix build on main #796

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Update deps, fix build on main #796

merged 6 commits into from
Jan 29, 2025

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Jan 28, 2025

  • Have you signed the CLA?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 28, 2025
❯ uv lock --upgrade
Updated codespell v2.4.0 -> v2.4.1
Updated craft-application v4.6.0 -> v4.8.2
Updated craft-parts v2.3.0 -> v2.4.1
Updated isort v5.13.2 -> v6.0.0
Updated pylint v3.3.3 -> v3.3.4
Updated sphinx-notfound-page v1.0.4 -> v1.1.0
Poetry >=2.0 drops support for the "export" command by default, delegating it
to the poetry-plugin-export plugin. These are dev-dependencies only.
The test builds the docs over the project files that are sent to the spread
worker. However, these files might include files generated by spread tests
that executed first, making the test fail unpredictably.
@tigarmo tigarmo marked this pull request as ready for review January 29, 2025 18:53
@tigarmo tigarmo requested review from bepri and a team January 29, 2025 19:15
@bepri bepri requested a review from a team January 29, 2025 20:06
@lengau
Copy link
Contributor

lengau commented Jan 29, 2025

Re: Spread test failures: I'm not sure why they're failing, but they appear to be reaching the right point. We're matching on "No suitable Python interpreter found, giving up." which we do get to, but for some reason doesn't get included in the output:

:: ++ find /root/parts/my-part/install/usr/bin /root/stage/usr/bin -type f -executable -name python3.10 -print -quit
:: + payload_python=
:: + '[' -n '' ']'
:: + echo 'Python interpreter not found in payload.'
:: + symlink_target=
:: Python interpreter not found in payload.
:: + '[' -z '' ']'
Failed to run the build script for part 'my-part'.
Detailed information: 
:: + '[' -z '' ']'
Recommended resolution: Check the build output and verify the project can work with the 'python' plugin.
For more information, check out: https://documentation.ubuntu.com/rockcraft/en/latest/reference/plugins.html
Failed to execute rockcraft in instance.
Full execution log: '/root/.local/state/rockcraft/log/rockcraft-20250129-165952.401190.log'

I don't think these are reversions - they look more like flaky tests to me. Under that presumption I'm approving

@tigarmo
Copy link
Collaborator Author

tigarmo commented Jan 29, 2025

Re: Spread test failures: I'm not sure why they're failing, but they appear to be reaching the right point. We're matching on "No suitable Python interpreter found, giving up." which we do get to, but for some reason doesn't get included in the output:

:: ++ find /root/parts/my-part/install/usr/bin /root/stage/usr/bin -type f -executable -name python3.10 -print -quit
:: + payload_python=
:: + '[' -n '' ']'
:: + echo 'Python interpreter not found in payload.'
:: + symlink_target=
:: Python interpreter not found in payload.
:: + '[' -z '' ']'
Failed to run the build script for part 'my-part'.
Detailed information: 
:: + '[' -z '' ']'
Recommended resolution: Check the build output and verify the project can work with the 'python' plugin.
For more information, check out: https://documentation.ubuntu.com/rockcraft/en/latest/reference/plugins.html
Failed to execute rockcraft in instance.
Full execution log: '/root/.local/state/rockcraft/log/rockcraft-20250129-165952.401190.log'

I don't think these are reversions - they look more like flaky tests to me. Under that presumption I'm approving

I'm 90% sure that the new error-output-handling is flaky in this special case. That expected line is the very last line of error output, and sometimes the test passes.

@lengau
Copy link
Contributor

lengau commented Jan 29, 2025

@tigarmo makes sense to me. I can't replicate the issue on my own machine.

@tigarmo tigarmo merged commit 6f1048a into main Jan 29, 2025
17 of 18 checks passed
@tigarmo tigarmo deleted the work/update-deps branch January 29, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants