[WIP] feat: express JS #781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yanksyoon
commented
Dec 19, 2024
yanksyoon
commented
- Have you signed the CLA?
rockcraft/extensions/express.py
Outdated
There was a problem hiding this comment.
Thanks, in general perhaps a better reference is https://github.com/canonical/rockcraft/blob/main/rockcraft/extensions/fastapi.py as it is stand-alone. Flask is unique because it shares a common parent class for Django
There was a problem hiding this comment.
We'll need:
- Docs (tutorial, reference)
- Spread test for the tutorial
- Unit tests
Also check anywhere that mentions fast-api framework and check if we need to do something similar for expressjs-framework
|
Closing (Opened #784) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.