fix(tests): don't use chisel slices in 'devel' bases #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that chisel releases necessarily lag behind mainline Ubuntu development, as each new series needs to be manually added to the chisel-releases repo. The case in point here is that 'devel' has just started to mean "Ubuntu 24.10", but this version is not available in chisel-releases yet. So we drop the use of slices in 'devel' tests, which should be fine because the point is to see whether the *rest* of Rockcraft's execution works.
mr-cal
approved these changes
May 9, 2024
lengau
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that chisel releases necessarily lag behind mainline Ubuntu development, as each new series needs to be manually added to the chisel-releases repo. The case in point here is that 'devel' has just started to mean "Ubuntu 24.10", but this version is not available in chisel-releases yet.
So we drop the use of slices in 'devel' tests, which should be fine because the point is to see whether the rest of Rockcraft's execution works.