Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chisel): update Chisel to v0.8.1 #449

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

cjdcordeiro
Copy link
Collaborator

  • Have you signed the CLA?

In preparation for a coming backward incompatible Chisel release, this PR is updating the Chisel version to a patch release that will allow for a longer grace migration period.

@cjdcordeiro
Copy link
Collaborator Author

@tigarmo have you seen this snapcraft error? I can't reproduce it locally

@tigarmo
Copy link
Collaborator

tigarmo commented Dec 14, 2023

I think there's some non-determinism here because both the skopeo and chisel parts declare different channels for the go build-snap (we probably want to detect that somehow @cmatsuoka)
So what's happening there is that chisel is being built with go 1.17

@cjdcordeiro
Copy link
Collaborator Author

Alright, despite the glitch, this should work around it

snap/snapcraft.yaml Show resolved Hide resolved
@tigarmo tigarmo merged commit 99443ee into canonical:main Dec 15, 2023
10 checks passed
tigarmo added a commit to canonical/snapcraft that referenced this pull request Jan 15, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449
tigarmo added a commit to canonical/craft-parts that referenced this pull request Jan 16, 2024
A new version of chisel-releases breaks compatibility with chisel
binaries older than v0.8.1.

Ref: canonical/rockcraft#449
tigarmo added a commit to canonical/craft-parts that referenced this pull request Jan 16, 2024
A new version of chisel-releases breaks compatibility with chisel
binaries older than v0.8.1. Note that we can't use the chisel snap
because the tests write into /tmp and the strict snap can't do that.

Ref: canonical/rockcraft#449
mr-cal pushed a commit to canonical/craft-parts that referenced this pull request Jan 16, 2024
A new version of chisel-releases breaks compatibility with chisel
binaries older than v0.8.1. Note that we can't use the chisel snap
because the tests write into /tmp and the strict snap can't do that.

Ref: canonical/rockcraft#449
mr-cal pushed a commit to canonical/snapcraft that referenced this pull request Jan 17, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449
mr-cal pushed a commit to canonical/craft-parts that referenced this pull request Jan 17, 2024
A new version of chisel-releases breaks compatibility with chisel
binaries older than v0.8.1. Note that we can't use the chisel snap
because the tests write into /tmp and the strict snap can't do that.

Ref: canonical/rockcraft#449
sergiusens pushed a commit to canonical/snapcraft that referenced this pull request Jan 17, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449
lengau pushed a commit to canonical/craft-parts that referenced this pull request Jan 18, 2024
A new version of chisel-releases breaks compatibility with chisel
binaries older than v0.8.1. Note that we can't use the chisel snap
because the tests write into /tmp and the strict snap can't do that.

Ref: canonical/rockcraft#449

Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
syu-w pushed a commit to canonical/snapcraft that referenced this pull request Jan 29, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449
mr-cal pushed a commit to canonical/snapcraft that referenced this pull request Feb 6, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449
mr-cal added a commit to canonical/snapcraft that referenced this pull request Feb 7, 2024
Upcoming Chisel (and chisel-releases) changes will break older versions
of the tool; update it to v0.8.1 which is compatible with this change
and gives us some breathing room before we change the way Chisel is
provisioned.

Ref: canonical/rockcraft#449

Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants