Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(backport): Juju, charmcraft, and dependency upgrades #82

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Feb 7, 2025

Closes #81.

This PR backports the upgrade of Juju, charmcraft, and the dependency upgrades

* Bump juju to 3.6/stable
* For uniformity, use charmcraft from 3.x/stable

Ref canonical/bundle-kubeflow#1176
* Pin pip to 24.2 due to jazzband/pip-tools#2131
* Update python dependencies using 'tox -e update-requirements'

Ref canonical/bundle-kubeflow#1177
Ref canonical/bundle-kubeflow#1185
* Bump libraries using charmcraft fetch-lib.
* Check for major versions using noctua charm libraries check --major. If there is one, then commit a do-not-merge-message.txt file.

Ref canonical/bundle-kubeflow#1184
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come that the libraries and microk8s commits are reverted? My suggesiton would be to include those in the PR and remove the "revert commits" since this will land as a merge commit in the commit history and we don't need them.

@mvlassis mvlassis force-pushed the kf-6901-backport-ci branch from fe670da to 9f5cd5c Compare February 10, 2025 12:19
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget to use a merge commit since this is a backport

@mvlassis mvlassis merged commit d2915b7 into track/2.0 Feb 11, 2025
9 checks passed
@mvlassis mvlassis deleted the kf-6901-backport-ci branch February 11, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants