Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move has_metric #406

Merged
merged 3 commits into from
Dec 1, 2022
Merged

move has_metric #406

merged 3 commits into from
Dec 1, 2022

Conversation

beliaev-maksim
Copy link
Member

refactoring

@beliaev-maksim
Copy link
Member Author

@sed-i
I believe that it is unrelated itest failure. test looks to be unstable

how can we update the test to make it working ?

sed-i
sed-i reviewed Nov 29, 2022
View reviewed changes
tests/integration/helpers.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@sed-i
Copy link
Contributor

sed-i commented Nov 29, 2022 •
edited
Loading

@sed-i I believe that it is unrelated itest failure. test looks to be unstable

how can we update the test to make it working ?

unit-1 of prom has an outdated url: fqdn instead of ingress:

"[http://prometheus-1.prometheus-endpoints.test-external-url-imkm.svc.cluster.local:80/metrics](http://prometheus-1.prometheus-endpoints.test-external-url-imkm.svc.cluster.local/metrics)"

(unit-0 has the correct ingress url).

This might be due to canonical/traefik-k8s-operator#107

@beliaev-maksim @sed-i
Update tests/integration/helpers.py
27d9995 
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
@beliaev-maksim
Copy link
Member Author

This might be due to canonical/traefik-k8s-operator#107

@sed-i
if I got it right, nothing we can do in this repo for now, right?

@sed-i sed-i merged commit bff7922 into canonical:main Dec 1, 2022
@beliaev-maksim beliaev-maksim deleted the move_has_metric branch December 1, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i approved these changes

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@rbarry82 rbarry82 Awaiting requested review from rbarry82

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beliaev-maksim @sed-i @Abuelodelanada