Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6678] PostgreSQL Config Improvement #778

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

Pepsiqqq
Copy link

This is copy of K8s PR, however there is an issue that PostgreSQL stucks in Awaiting for member to start. I think it's related to this issue because there is the same error (Failed to list PostgreSQL database users: could not translate host name "None" to address: Temporary failure in name resolution). On K8s side everything works as intended.

Added all missing parameters from PostgreSQL config analysis (Added params 25.05):
https://docs.google.com/spreadsheets/d/1CbJMmSSP5eyu08y5vM8RNGrjiSxOLsa7RelwwUsi-vg/edit?pli=1&gid=815242942#gid=815242942

Were not added:

  1. client_encoding: Session only parameter that can't be set by Patroni. Source
  2. transaction_deferrable: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source
  3. transaction_isolation: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source
  4. transaction_read_only: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source

Notice:

  1. old_snapshot_threshold: Will be deleted in 17 version. Source
  2. default_table_access_method: Added dynamic validation.

Also sorted config to improve readability.

@dragomirp dragomirp requested review from a team, taurus-forever, dragomirp and marceloneppel and removed request for a team February 20, 2025 11:19
@dragomirp dragomirp added the enhancement New feature, UI change, or workload upgrade label Feb 21, 2025
@Pepsiqqq Pepsiqqq changed the title PostgreSQL Config Improvement [DPE-6678] PostgreSQL Config Improvement Feb 24, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 75.11962% with 104 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (5a7defe) to head (b42d59d).

Files with missing lines Patch % Lines
src/config.py 75.48% 51 Missing and 51 partials ⚠️
src/charm.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   71.97%   72.11%   +0.13%     
==========================================
  Files          15       15              
  Lines        3479     3862     +383     
  Branches      532      583      +51     
==========================================
+ Hits         2504     2785     +281     
- Misses        845      897      +52     
- Partials      130      180      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	lib/charms/postgresql_k8s/v0/postgresql.py
@dragomirp
Copy link
Contributor

Hi, @Pepsiqqq, please sync up with main, it should skip the tests that cannot run on forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, UI change, or workload upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants