-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-6678] PostgreSQL Config Improvement #778
Open
Pepsiqqq
wants to merge
27
commits into
canonical:main
Choose a base branch
from
Pepsiqqq:config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,297
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 71.97% 72.11% +0.13%
==========================================
Files 15 15
Lines 3479 3862 +383
Branches 532 583 +51
==========================================
+ Hits 2504 2785 +281
- Misses 845 897 +52
- Partials 130 180 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marceloneppel
approved these changes
Feb 25, 2025
# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py
taurus-forever
approved these changes
Mar 10, 2025
Hi, @Pepsiqqq, please sync up with main, it should skip the tests that cannot run on forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is copy of K8s PR, however there is an issue that PostgreSQL stucks in
Awaiting for member to start
. I think it's related to this issue because there is the same error (Failed to list PostgreSQL database users: could not translate host name "None" to address: Temporary failure in name resolution
). On K8s side everything works as intended.Added all missing parameters from PostgreSQL config analysis (Added params 25.05):
https://docs.google.com/spreadsheets/d/1CbJMmSSP5eyu08y5vM8RNGrjiSxOLsa7RelwwUsi-vg/edit?pli=1&gid=815242942#gid=815242942
Were not added:
client_encoding
: Session only parameter that can't be set by Patroni. Sourcetransaction_deferrable
: This parameter cannot be set in the configuration file, or from any source other than live SQL. Sourcetransaction_isolation
: This parameter cannot be set in the configuration file, or from any source other than live SQL. Sourcetransaction_read_only
: This parameter cannot be set in the configuration file, or from any source other than live SQL. SourceNotice:
old_snapshot_threshold
: Will be deleted in 17 version. Sourcedefault_table_access_method
: Added dynamic validation.Also sorted config to improve readability.