Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6056] Add preload libs to regular startup parameters #741

Merged
merged 3 commits into from
Jan 27, 2025
Merged

[DPE-6056] Add preload libs to regular startup parameters #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a5dbb9
Add preload libs to regular startup params
dragomirp Jan 24, 2025
bd1df49
Bump timeout
dragomirp Jan 24, 2025
bd5503c
Merge branch 'main' into dpe-6056-pgaudit
dragomirp Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/patroni.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ postgresql:
bin_dir: /snap/charmed-postgresql/current/usr/lib/postgresql/{{ version }}/bin
data_dir: {{ data_path }}
parameters:
shared_preload_libraries: 'timescaledb,pgaudit'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does CI tests passed with this line? LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue affects only the followers, which is why the tests pass. I think going forward we should try to move most (all?) bootstrap params into the regular params, so we have a single source of truth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. the patch should work AS IS, AFAIK. Do you want to merge it or proceed with refactoring now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. the patch should work AS IS, AFAIK. Do you want to merge it or proceed with refactoring now?

Let's merge this as is and leave the refactoring for better days.

{%- if enable_pgbackrest_archiving %}
archive_command: 'pgbackrest {{ pgbackrest_configuration_file }} --stanza={{ stanza }} archive-push %p'
{% else %}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/ha_tests/test_upgrade_from_stable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

logger = logging.getLogger(__name__)

TIMEOUT = 600
TIMEOUT = 900
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timing out on CI e.g. https://github.com/canonical/postgresql-operator/actions/runs/12948714150/job/36124952260



@pytest.mark.group(1)
Expand Down
Loading