[DPE-5706] remove clutter from singlestat panels in cos #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,7 +212,7 @@ | |||
| "tableColumn": "", | |||
| "targets": [ | |||
| { | |||
| "expr": "process_start_time_seconds{release=\"$release\", instance=\"$instance\"} * 1000", | |||
| "expr": "min(process_start_time_seconds{release=\"$release\", instance=\"$instance\"} * 1000) by (label)", | |||
There was a problem hiding this comment.
Picks the oldest start time across the selected units.
| @@ -246,7 +246,7 @@ | |||
| }, | |||
| "editorMode": "code", | |||
| "exemplar": false, | |||
| "expr": "patroni_dcs_last_seen{service_name=~\"$service_name\",scope=~\"$scope_name\"}*1000", | |||
| "expr": "max(patroni_dcs_last_seen{service_name=~\"$service_name\",scope=~\"$scope_name\"}*1000) by (label)", | |||
There was a problem hiding this comment.
Picks the most recent Last Seen time across selected units
| @@ -826,7 +826,7 @@ | |||
| }, | |||
| "editorMode": "code", | |||
| "exemplar": false, | |||
| "expr": "patroni_postmaster_start_time{service_name=~\"$service_name\",scope=~\"$scope_name\"}*1000", | |||
| "expr": "min(patroni_postmaster_start_time{service_name=~\"$service_name\",scope=~\"$scope_name\"}*1000) by (label)", | |||
There was a problem hiding this comment.
picks the oldest start time across selected units
lucasgameiroborges
requested review from
dragomirp,
taurus-forever and
marceloneppel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 71.82% 71.82%
=======================================
Files 13 13
Lines 3219 3219
Branches 477 477
=======================================
Hits 2312 2312
Misses 791 791
Partials 116 116 ☔ View full report in Codecov by Sentry. |
marceloneppel
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR focuses on addressing #656 in particular.
Solution
This comes down to select the appropriate value (amongst the possible
juju-unitlabels) and display it on the singlestat panel. There are 3 main cases:avgormin/maxdoesn't work, hence the usage oftopk(1, <version_metric>)to just pick a value.maxor oldestmintimestamp among the possible unit's values. Depends on the metric, will put comments on what was chosen and where.min/max, just in case they end up being different. Here, I chose to pick the largest value by default.Please, let me know if all this makes sense!