-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4759] Bump version #510
Conversation
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 11 11
Lines 2870 2870
Branches 508 508
=======================================
Hits 2001 2001
Misses 763 763
Partials 106 106 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 @carlcsaposs-canonical should we use charm version 2
here or better 1.0.1
or alike , re: versioning on upgrade.
this uses the upgrade lib, not router/opensearch/mongodb shared code, so no clue router/opensearch/mongodb default behavior is to mark major version changes as incompatible I think the lib uses |
Issue
_on_upgrade_charm_check_legacy()
logic is leading to a slow bootstrap of replicas.This method is not needed anymore (only when upgrading from revision 288).
Solution
Bump the version in
src/dependency.json
so that after the next stable, we can bump the restrictions (upgrade_supported
field) to allow the upgrade only from the latest stable (which will allow us to remove_on_upgrade_charm_check_legacy()
).