Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4759] Bump version #510

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[DPE-4759] Bump version #510

merged 2 commits into from
Jun 27, 2024

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Jun 25, 2024

Issue

_on_upgrade_charm_check_legacy() logic is leading to a slow bootstrap of replicas.

This method is not needed anymore (only when upgrading from revision 288).

Solution

Bump the version in src/dependency.json so that after the next stable, we can bump the restrictions (upgrade_supported field) to allow the upgrade only from the latest stable (which will allow us to remove _on_upgrade_charm_check_legacy()).

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (885ab0c) to head (59a5d94).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          11       11           
  Lines        2870     2870           
  Branches      508      508           
=======================================
  Hits         2001     2001           
  Misses        763      763           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel marceloneppel marked this pull request as ready for review June 26, 2024 13:11
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 @carlcsaposs-canonical should we use charm version 2 here or better 1.0.1 or alike , re: versioning on upgrade.

@carlcsaposs-canonical
Copy link
Contributor

2 @carlcsaposs-canonical should we use charm version 2 here or better 1.0.1 or alike , re: versioning on upgrade.

this uses the upgrade lib, not router/opensearch/mongodb shared code, so no clue

router/opensearch/mongodb default behavior is to mark major version changes as incompatible

I think the lib uses "upgrade_supported", but believe you have to predict the future there (i.e. it checks the value in the old charm) IIRC, but not sure if that's changed

@marceloneppel marceloneppel merged commit 4ac3b7f into main Jun 27, 2024
72 of 73 checks passed
@marceloneppel marceloneppel deleted the dpe-4759-bump-version branch June 27, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants