-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS implementation #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
marceloneppel
requested review from
delgod,
zmraul,
shayancanonical,
marcoppenheimer,
Mehdi-Bendriss,
MiaAltieri,
paulomach and
WRFitch
September 14, 2022 15:15
WRFitch
approved these changes
Sep 14, 2022
zmraul
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Add TLS implementation * Delete file * Update library * Fix PostgreSQL library * Add jsonschema as a binary dependency * Change hostname to unit ip * Add unit test dependency * Call certificate update on config change * Fix docstring * Change log call
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-operator
that referenced
this pull request
May 19, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-operator
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
REPLICATING
what was already reviewed on TLS implementation postgresql-k8s-operator#36 to the PostgreSQL VM charm.FOCUS
your review on:src/charm.py
(ignoring the changes toget_secret
andset_secret
methods, which was only a refactor needed to use them outside the class, like in lib/charms/postgresql_k8s/v0/postgresql_tls.py; FOCUS on the other methods, that push TLS files to the workload directory and later enable/disable TLS, also performing a rolling restart, which is needed for the other instances to start to use TLS in the replication connection). Also, there is a way to update the certificates if the unit IP changes.templates/patroni.yml.j2
(changes to enable/disable SSL in the client and other instances connections; this is something specific to PostgreSQL/Patroni)ip-172-31-54-71
) in clouds other than LXD (like AWS), so they will also change with the IP addresses changing (so the IP address is used as the hostname can behave even different on other clouds).Testing
tests/unit/test_charm.py
andtests/unit/test_patroni.py
.Release Notes