Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5827] Set all nodes to synchronous replicas #784

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Merge branch 'main' into dpe-5827-all-sync

372048d
Select commit
Loading
Failed to load commit list.
Open

[DPE-5827] Set all nodes to synchronous replicas #784

Merge branch 'main' into dpe-5827-all-sync
372048d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

75.45% (target 70.00%)

View this Pull Request on Codecov

75.45% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.45%. Comparing base (a5c0344) to head (372048d).

Files with missing lines Patch % Lines
src/charm.py 53.84% 6 Missing ⚠️
src/patroni.py 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   75.53%   75.45%   -0.09%     
==========================================
  Files          12       12              
  Lines        3115     3145      +30     
  Branches      466      470       +4     
==========================================
+ Hits         2353     2373      +20     
- Misses        621      630       +9     
- Partials      141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.