[DPE-5915] Reduce pgdate permissions #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 12 12
Lines 3110 3110
Branches 474 474
=======================================
Hits 2353 2353
Misses 614 614
Partials 143 143 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Nov 7, 2024
| @@ -668,6 +668,7 @@ async def test_discourse(ops_test: OpsTest): | |||
|
|
|||
|
|
|||
| @pytest.mark.group(1) | |||
| @pytest.mark.unstable | |||
There was a problem hiding this comment.
Indico test fails due to the DB charm blocking over running out of space on the volume. Disabling to fix in a separate PR.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
lucasgameiroborges
approved these changes
Nov 7, 2024
taurus-forever
approved these changes
Nov 7, 2024
| @@ -903,7 +903,7 @@ def _create_pgdata(self, container: Container): | |||
| """Create the PostgreSQL data directory.""" | |||
| if not container.exists(self.pgdata_path): | |||
| container.make_dir( | |||
| self.pgdata_path, permissions=0o770, user=WORKLOAD_OS_USER, group=WORKLOAD_OS_GROUP | |||
There was a problem hiding this comment.
For the history, it has been noticed on Sept 23 while working on Juju 3.6 beta testing, but left unrecognised in daily routine: 52271e1
TIL!
dragomirp
added a commit
that referenced
this pull request
Nov 8, 2024
* Reduce pgdate permissions * Disable indico tests
dragomirp
added a commit
that referenced
this pull request
Nov 8, 2024
* Reduce pgdate permissions * Disable indico tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replica units fail to initialize on Juju 3.6 due to too restrictive permissions rejected by initdb.
Reducing permissions to the maximum accepted by initdb.
Tech details:
Previously in Juju 3.5, the old Pebble 1.10 ignored our 0770 and set 0750 => everything worked well.
In Juju 3.6-rc1, the new Pebble 1.16 shipped.
Meanwhile, the Pebble 1.12 has fixed mkdir.
As a result our 0770 is how set properly causing regression as PG/initdb accept 0750 maximum.
Fixes: #760
and https://warthogs.atlassian.net/browse/DPE-5915