Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5662] increase async replication tests coverage #748

Merged

Conversation

imanenami
Copy link
Contributor

@imanenami imanenami commented Oct 18, 2024

Issue

#739

Solution

Improved relations.async_replication module test coverage to ~65

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (2a53fa3) to head (c372ded).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   71.65%   76.43%   +4.77%     
==========================================
  Files          11       12       +1     
  Lines        3031     3047      +16     
  Branches      464      465       +1     
==========================================
+ Hits         2172     2329     +157     
+ Misses        753      581     -172     
- Partials      106      137      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imanenami imanenami force-pushed the improve-async-replication-testcov branch from 18b8aa4 to 35cbf14 Compare October 18, 2024 06:33
@dragomirp dragomirp requested review from a team, taurus-forever, dragomirp, marceloneppel and lucasgameiroborges and removed request for a team October 18, 2024 13:47
@imanenami imanenami force-pushed the improve-async-replication-testcov branch from 35cbf14 to c372ded Compare October 18, 2024 14:42
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Could you accept the CLA?

@dragomirp dragomirp merged commit dfab630 into canonical:main Oct 30, 2024
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants