-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5658] Update COS alert rules #727
Conversation
Minor edits and polished yaml formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 70.65% 71.74% +1.08%
==========================================
Files 11 12 +1
Lines 2999 3047 +48
Branches 523 465 -58
==========================================
+ Hits 2119 2186 +67
+ Misses 767 754 -13
+ Partials 113 107 -6 ☔ View full report in Codecov by Sentry. |
Minor edits and polished yaml formatting
Minor edits and polished yaml formatting
Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Using backticks for the alert manager to render newlines correctly.
Using backticks for the alert manager to render newlines correctly.
Formatting
Formatting
Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Andreia!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question "VALUE" has been randomly removed. Can you please explain it. Tnx!
@taurus-forever Merging to keep updated with other SQL repos. Future work is planned to investigate these variables and continue improving the rules. |
Issue
Alert rule descriptions do not provide much guidance about what actions the user can take.
Solution
Improve the descriptions of the COS alert rule expressions.
The format should be:
Here is a good example: