Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix for blocked CI #533

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Quick fix for blocked CI #533

merged 2 commits into from
Jun 27, 2024

Conversation

lucasgameiroborges
Copy link
Member

@lucasgameiroborges lucasgameiroborges commented Jun 26, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (50f49ba) to head (0de22df).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files          10       10           
  Lines        2785     2785           
  Branches      518      518           
=======================================
  Hits         1956     1956           
  Misses        731      731           
  Partials       98       98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marceloneppel
marceloneppel approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lucasgameiroborges!

@lucasgameiroborges lucasgameiroborges marked this pull request as ready for review June 27, 2024 13:36
@lucasgameiroborges lucasgameiroborges changed the title fixes Quick fix for blocked CI Jun 27, 2024
@dragomirp dragomirp mentioned this pull request Jun 27, 2024
Open
@lucasgameiroborges lucasgameiroborges merged commit 172baf6 into main Jun 27, 2024
72 checks passed
@lucasgameiroborges lucasgameiroborges deleted the lucas/try-fix-release branch June 27, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@dragomirp dragomirp dragomirp approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasgameiroborges @taurus-forever @dragomirp @marceloneppel